fix route:cache and config:cache issue #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For curiosity's sake, why are route bindings being done in the service provider? Does route:cache prevent them from working in the route files? |
|
@mikemand I had the same question too :D . It actually makes sense, once cached, laravel won't open those route files anymore, and thus we would lose the binding, causing 404's etc. Thanks @huydang284 for sending on 3.0, will check it out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nWidart,
This is my pull request in Asgard version 3.
Pull request in version 2: #544
Please merge.
Thank you,
Huy Dang